bring in circleci module #5047
Merged
bring in circleci module #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itay Donanhirsh <[email protected]>
|
/rk-bless |
|
/cancel-circle 123920 |
|
/retest |
|
🔨 rebuilding |
|
/assign @htuch @mattklein123 |
|
/retest |
|
🔨 rebuilding |
|
/rk-unbless |
|
I'd like to get this in, then make a demo PR, then write docs that point to it. Will be much less noisier on the demo PR. |
|
OK SGTM |
mattklein123
approved these changes
Nov 16, 2018
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Itay Donanhirsh <[email protected]> Signed-off-by: Fred Douglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Itay Donanhirsh [email protected]
Description:
Bring in repokitteh's circleci module. This will allow people to
/retesttheir change in CI.Risk Level:
Low.
Testing:
See this PR.
Docs Changes:
Upcoming PR.
Release Notes:
None.