Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repokitteh: change use path #4957

Merged
merged 1 commit into from
Nov 5, 2018
Merged

repokitteh: change use path #4957

merged 1 commit into from
Nov 5, 2018

Conversation

itayd
Copy link
Contributor

@itayd itayd commented Nov 4, 2018

Signed-off-by: Itay Donanhirsh [email protected]

Description:
Moved modules to a simpler path. Adapt envoy to that.

Risk Level:
None

Testing:
envoyproxy/envoybot#10

Docs Changes:
Change link in docs.

Signed-off-by: Itay Donanhirsh <[email protected]>
@itayd
Copy link
Contributor Author

itayd commented Nov 4, 2018

/rk-bless

@repokitteh-read-only
Copy link

This PR has been blessed, meaning its repokitteh changes are in effect in this PR.
This is, however, for a limitted time (1h0m0s). In order to renew the blessing, please close and reopoen this PR.

😽

Caused by: #4957 was labeled by repokitteh[bot].

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Nov 4, 2018

/assign @mattklein123

@itayd
Copy link
Contributor Author

itayd commented Nov 4, 2018

/rk-unbless

use("github.com/softkitteh/repokitteh-modules/assign.star")
use("github.com/softkitteh/repokitteh-modules/review.star")
use("github.com/softkitteh/repokitteh-modules/wait.star")
use("github.com/repokitteh/modules/assign.star")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itayd one thought here for a future PR. I think when we import modules into our repo we should do it by SHA so that we can clearly track what code we are using? Thoughts on doing that in a follow up? cc @htuch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattklein123 sure thing. for now it's easier to refactor things behind the scenes without causing interruption, but i'll pin the shas in next pr.

@mattklein123 mattklein123 merged commit 95f688a into envoyproxy:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants