reokitteh: bring in wait module #4956
Conversation
Signed-off-by: Itay Donanhirsh <[email protected]>
|
/rk-bless |
|
look at me waiting for something /wait |
|
now i say something without '/waiting' to cause the label to go away |
|
now i'll wait again AND assign this to someone /assign @mattklein123 |
|
ok @mattklein123 i hope this makes you happy :) /wait |
|
(do not merge yet - i need to do docs) |
Signed-off-by: Itay Donanhirsh <[email protected]>
|
@mattklein123 your turn. /assign @mattklein123 |
|
/rk-unbless |
|
/rk-bless |
|
got an issue with blessing after push i think. will check. now work! /wait |
|
/wait |
|
/wait |
|
/wait |
|
/assign |
|
/unassign |
|
/wait |
|
this should work fine after merge. i'll debug the weird behavior anyway. /wait |
|
This is amazing, thanks. Question: What is the "bless" and "unbless" stuff? Is that somehow so you can test before merge? |
|
@mattklein123 yes - see #4956 (comment). if anything was active once pr is active, some evil actor could just open a pr and do what they want. that's why only specific people (currently me and @htuch) can bless prs. who can do it is in a configuration file on the kitteh's side. down they road it'll all be available through some kind of ui and/or api. |
|
Got it. OK this is amazing. I'm going to go wait all my PRs! |
|
👍 i'm pretty sure we'll wont adjustments to this, so feel free to ask. |
Signed-off-by: Itay Donanhirsh [email protected]
Description:
Bring in `/wait' command - see inside for doc changes.
Risk Level:
None.
Testing:
See this PR.
Docs Changes:
See inside.
Release Notes:
None