repokitteh: add support for randomized auto-assign. #14185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to pick dedicated API shepherds for each PR, ensuring we have clear review ownership. Fixes envoyproxy#13350 Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
|
This is now works and is ready for review, thanks. |
|
side q: How this is automatically assigned without blessing rk? :D |
lizan
reviewed
Nov 25, 2020
Signed-off-by: Harvey Tuch <[email protected]>
|
/rk-bless |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
htuch
commented
Nov 26, 2020
| @@ -152,20 +159,19 @@ def _reconcile(config, specs=None): | |||
| return results | |||
|
|
|||
|
|
|||
| def _comment(config, results, force=False): | |||
| def _comment(config, results, assignees, sender, force=False): | |||
There was a problem hiding this comment.
@itayd is this the right way to get at PR author? If not can you suggest an alternative method? Would be nice to have this keyword-literal args documented to be able to figure out semantics.
There was a problem hiding this comment.
i think it is the author. to be sure though you can access the raw event using the event parameter: event.comment.user (see for example https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/814a4880-32c4-11eb-8650-62ce98aed958).
lizan
approved these changes
Nov 26, 2020
|
lgtm |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Dec 2, 2020
* master: (70 commits) upstream: avoid reset after end_stream in TCP HTTP upstream (envoyproxy#14106) bazelci: add fuzz coverage (envoyproxy#14179) dependencies: allowlist CVE-2020-8277 to prevent false positives. (envoyproxy#14228) cleanup: replace ad-hoc [0, 1] value types with UnitFloat (envoyproxy#14081) Update docs for skywalking tracer (envoyproxy#14210) Fix some errors in the switch statement when decode dubbo response (envoyproxy#14207) Windows: enable tests and envoy-static.exe pdb file (envoyproxy#13688) http: add Kill Request HTTP filter (envoyproxy#14170) dependencies: fix release_dates error behavior. (envoyproxy#14216) thrift filter: support skip decoding data after metadata in the thrift message (envoyproxy#13592) update cares (envoyproxy#14213) docs: clarify behavior of hedge_on_per_try_timeout (envoyproxy#12983) repokitteh: add support for randomized auto-assign. (envoyproxy#14185) [grpc] validate grpc config for illegal characters (envoyproxy#14129) server: Return nullopt when process_context is nullptr (envoyproxy#14181) [Windows] Fix thrift proxy tests (envoyproxy#13220) kafka: add missing unit tests (envoyproxy#14195) doc: mention gperftools explicitly in PPROF.md (envoyproxy#14199) Removed `--use-fake-symbol-table` option. (envoyproxy#14178) filter contract: clarification around local replies (envoyproxy#14193) ... Signed-off-by: Michael Puncel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to pick dedicated API shepherds for each PR, ensuring
we have clear review ownership.
Fixes #13350
Signed-off-by: Harvey Tuch [email protected]