Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repokitteh: enhance dependency-shepherds rules. #13675

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

htuch
Copy link
Member

@htuch htuch commented Oct 21, 2020

  • Monitor all *.patch files; we want fewer of these for release update
    velocity reasons (with the resulting security win).

  • Make dependency-shepherds check not subject to global approval. The
    dependency shepherds will need to perform an explicit "/lgtm deps" to
    prevent accidental merge. This extra steps establishes a checklist philosophy
    during dependency review.

Signed-off-by: Harvey Tuch [email protected]

* Monitor all *.patch files; we want fewer of these for release update
  velocity reasons (with the resulting security win).

* Make dependency-shepherds check not subject to global approval. The
  dependency shepherds will need to perform an explicit "/lgtm deps" to
  prevent accidental merge.

Signed-off-by: Harvey Tuch <[email protected]>
Copy link
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattklein123 mattklein123 merged commit fa98a71 into envoyproxy:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants