repokitteh: Add welcome message for new contributors #13309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @itayd |
phlax
commented
Sep 29, 2020
phlax
commented
Sep 29, 2020
phlax
force-pushed
the
repokitteh-welcome
branch
from
a9b8780
to
0f7a98d
Compare
phlax
commented
Sep 30, 2020
phlax
changed the title
phlax
force-pushed
the
repokitteh-welcome
branch
from
0f7a98d
to
221249a
Compare
phlax
force-pushed
the
repokitteh-welcome
branch
from
298eccf
to
221249a
Compare
Signed-off-by: Ryan Northey <[email protected]>
phlax
force-pushed
the
repokitteh-welcome
branch
from
ece29b7
to
5ad3a30
Compare
|
The output from the welcome message can be seen here #13306 (comment) |
Signed-off-by: Ryan Northey <[email protected]>
|
@itayd i think this one should be ready for review |
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
itayd
previously approved these changes
Oct 8, 2020
|
@mattklein123 it would be good to land this, and i would like to test it once it does |
mattklein123
requested changes
Oct 11, 2020
| @@ -0,0 +1,31 @@ | |||
|
|
|||
| NEW_CONTRIBUTOR_MESSAGE = """ | |||
| hi @%s, welcome and thankyou for your contribution. | |||
There was a problem hiding this comment.
Suggested change
| hi @%s, welcome and thankyou for your contribution. | |
| Hi @%s, welcome and thank you for your contribution. |
There was a problem hiding this comment.
Sorry, can you capitalize Hi?
/wait
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
|
@mattklein123 this doesnt seem to have worked on the first pass. I have pinged @itayd to see if we can trace why not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey [email protected]
Commit Message: repokitteh: Add welcome message for new contributors
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Partial fix for #13232
[Optional Deprecated:]