repokitteh: tighten API path expression. #11712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the number of false positives we see during review. API shepherds were being flagged on files in include/envoy/api for example. Signed-off-by: Harvey Tuch <[email protected]>
lizan
approved these changes
Jun 23, 2020
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Reduce the number of false positives we see during review. API shepherds were being flagged on files in include/envoy/api for example. Signed-off-by: Harvey Tuch <[email protected]>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Reduce the number of false positives we see during review. API shepherds were being flagged on files in include/envoy/api for example. Signed-off-by: Harvey Tuch <[email protected]> Signed-off-by: yashwant121 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the number of false positives we see during review. API shepherds
were being flagged on files in include/envoy/api for example.
Signed-off-by: Harvey Tuch [email protected]