ci: force /lgtm v2-freeze on any v2 API changes. #11092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To assist the API shepherds in ensuring that no unintentional v2 freezes creep in, this PR extends our forked ownerscheck.star to force a "/lgtm v2-freeze" to be issued in order for v2 API changes to merge. The changes made to ownerscheck.star are: * Replace path prefix matching with regex matching. * Allow global approvers to be opted out of; we don't want a PR "approve" stamp to allow merges without an explicit v2 related LGTM. Signed-off-by: Harvey Tuch <[email protected]>
|
/rk-bless |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
|
/rk-bless |
|
🙀 Error while processing event: |
Signed-off-by: Harvey Tuch <[email protected]>
|
/rk-bless |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/lgtm api |
Signed-off-by: Harvey Tuch <[email protected]>
|
/rk-bless |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
|
/lgtm api |
Signed-off-by: Harvey Tuch <[email protected]>
|
/rk-bless |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
|
@envoyproxy/api-shepherds can I get a test approval? Not planning on merging yet. |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
lizan
previously approved these changes
May 6, 2020
|
/lgtm v2-freeze |
|
/rk-bless |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
|
/rk-bless |
|
@itayd @envoyproxy/api-shepherds this is now ready for review, thanks! |
htuch
changed the title
itayd
reviewed
May 7, 2020
Signed-off-by: Harvey Tuch <[email protected]>
|
/rk-bless |
lizan
approved these changes
May 8, 2020
htuch
added a commit
to htuch/envoy
that referenced
this pull request
May 8, 2020
The **spec was dropped in envoyproxy#11092 when building the struct to pass around. This lost the owner info, resulting in errors such as https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/595f3d80-9170-11ea-9312-ad19ced22be2. Signed-off-by: Harvey Tuch <[email protected]>
htuch
added a commit
that referenced
this pull request
May 10, 2020
The **spec was dropped in #11092 when building the struct to pass around. This lost the owner info, resulting in errors such as https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/595f3d80-9170-11ea-9312-ad19ced22be2. Signed-off-by: Harvey Tuch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To assist the API shepherds in ensuring that no unintentional v2 freezes creep in, this PR extends
our forked ownerscheck.star to force a "/lgtm v2-freeze" to be issued in order for v2 API changes to
merge.
The changes made to ownerscheck.star are:
without an explicit v2 related LGTM.
Risk level: Low (CI only)
Testing: Manual interactions with RK in #11092
Signed-off-by: Harvey Tuch [email protected]