ci: fork repokitteh ownerscheck.star. #11090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per @itayd suggestion, forking ownerscheck.star so that we can add some improvements (regex matching, disabling of global approval) to support v2 freeze enforcement. Signed-off-by: Harvey Tuch <[email protected]>
|
/rk:bless |
|
Looks like this is still using github.com/repokitteh/modules/ownerscheck.star. |
|
/rk-bless |
|
/lgtm api |
Signed-off-by: Harvey Tuch <[email protected]>
|
This looks to be working; validated by blessing, verifying the forked ownerscheck.star is imported, then making a change that relied on behavior from ownerscheck.star, which triggered the correct RK behavior. |
|
Sorry does this PR have any functional changes? Or just the fork? |
|
@mattklein123 no functional changes, this is just to establish a baseline, I've amended the commit description. |
mattklein123
previously approved these changes
May 6, 2020
Signed-off-by: Harvey Tuch <[email protected]>
mrSeoD
pushed a commit
to mrSeoD/envoy
that referenced
this pull request
May 15, 2020
As per @itayd suggestion, forking ownerscheck.star so that we can add some improvements (regex matching, disabling of global approval) to support v2 freeze enforcement. There are no functional changes in this PR, it's just the baseline for later work. Signed-off-by: Harvey Tuch <[email protected]> Signed-off-by: mrSeoDavid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @itayd suggestion, forking ownerscheck.star so that we can add some improvements (regex
matching, disabling of global approval) to support v2 freeze enforcement.
There are no functional changes in this PR, it's just the baseline for later work.
Signed-off-by: Harvey Tuch [email protected]