-
Notifications
You must be signed in to change notification settings - Fork 231
feat: add derive network #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change introduces support for the "Derive" network across the codebase. It adds "Derive" to relevant enums, creates a new network configuration file, updates the network index to include Derive, and registers its Etherscan endpoint. The README is updated to mention Derive in the list of supported chains and improves formatting in several sections. No changes were made to the declarations of existing exported or public entities except for the addition of Derive-related constants and enum members. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Extension
participant DeriveNetwork
participant EtherscanEndpoint
User->>Extension: Selects Derive network
Extension->>DeriveNetwork: Loads Derive configuration
DeriveNetwork->>EtherscanEndpoint: Uses Derive explorer endpoint for activity
Extension->>User: Displays Derive network data and activities
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
packages/types/src/networks.ts
Outdated
| Story = "story", | ||
| Ink = "ink", | ||
| Taraxa = "taraxa", | ||
| Derive = "derive", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seems to not be in the coingecko platform api. Please make sure you added the right platform or remove if there isn't one. Here's the platform api for reference: https://api.coingecko.com/api/v3/coins/list?include_platform=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see a Derive in this one unless it's something else?
{"id":"derive","symbol":"drv","name":"Derive","platforms":{"ethereum":"0xb1d1eae60eea9525032a6dcb4c1ce336a1de71be","optimistic-ethereum":"0x33800de7e817a70a694f31476313a7c572bba100","arbitrum-one":"0x77b7787a09818502305c95d68a2571f090abb135","base":"0x9d0e8f5b25384c7310cb8c6ae32c8fbeb645d083"}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a token. If you look at the platforms, there isn't one platform for derive.
| node: 'https://rpc.derive.xyz', | ||
| icon, | ||
| coingeckoID: 'derive', | ||
| coingeckoPlatform: CoingeckoPlatform.Derive, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove coingeckoPlatform related to comment below.
Summary by CodeRabbit