[FIX] Total balance not updated when withdrawal completes #641

ahsan-javaiid · 2025-03-18T13:01:04Z

Description

This PR fixes the issue of total balance not refreshing after tx confirms. Due to this issue the individual and total balances does not match. When the withdrawal is processed, it is needed to refresh in order to see the total balance update.

Tested this on couple of EVM chains, it's happening on all EVM chains.

Snapshots

Summary by CodeRabbit

New Features
- The application now automatically refreshes the page once a transaction receipt is received, ensuring you always see the latest transaction status.
- Error handling behavior remains active, continuing to notify you of any issues during processing.

coderabbitai · 2025-03-18T13:01:13Z

Walkthrough

This change adds an event listener for the receipt event within the sendAction function of the transaction sending process. Upon receiving the transaction receipt, it triggers a page reload by invoking router.go(0). The existing error handling logic remains intact.

Changes

File	Change Summary
`packages/extension/src/providers/ethereum/ui/send-transaction/verify-transaction/index.vue`	Added a `receipt` event listener in the `sendAction` function to trigger a page reload with `router.go(0)` upon receiving the transaction receipt.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant SA as sendAction
    participant SST as sendSignedTransaction
    participant R as Router

    U->>SA: Initiates transaction sending
    SA->>SST: Calls sendSignedTransaction
    SST-->>SA: Emits receipt event
    SA->>R: Calls router.go(0) to reload page

Suggested reviewers

kvhnuke

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20d670c and c1b7136.

📒 Files selected for processing (1)

packages/extension/src/providers/ethereum/ui/send-transaction/verify-transaction/index.vue (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/extension/src/providers/ethereum/ui/send-transaction/verify-transaction/index.vue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ahsan-javaiid · 2025-03-18T13:01:50Z

cc: @kvhnuke for review. Thank you.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/extension/src/providers/ethereum/ui/send-transaction/verify-transaction/index.vue (1)
221-221: The fix addresses the balance update issue effectively.

Adding a page reload when the transaction receipt is received should successfully solve the reported problem by ensuring the total balance gets refreshed after a withdrawal completes.

While this solution works, consider a more targeted approach in the future that wouldn't require a full page reload:
-.on('receipt', () => router.go(0))
+.on('receipt', () => {
+  // Emit an event that balance components can listen for
+  const balanceUpdateEvent = new CustomEvent('balance:update', {
+    detail: { address: txData.fromAddress, network: network.value.name }
+  });
+  window.dispatchEvent(balanceUpdateEvent);
+})
This would require corresponding listeners in your balance components but would provide a smoother user experience without losing application state.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 048f6f5 and aa77ce6.

📒 Files selected for processing (1)

packages/extension/src/providers/ethereum/ui/send-transaction/verify-transaction/index.vue (1 hunks)

kvhnuke · 2025-04-24T17:44:40Z

@ahsan-javaiid can you rebase with latest changes

ahsan-javaiid · 2025-04-24T17:59:51Z

@ahsan-javaiid can you rebase with latest changes

Done!

coderabbitai bot reviewed Mar 18, 2025

View reviewed changes

coderabbitai bot approved these changes Mar 18, 2025

View reviewed changes

ahsan-javaiid force-pushed the fix/refresh-balance branch from aa77ce6 to 20d670c Compare April 24, 2025 17:53

fix: refresh balance on tx confirm

c1b7136

ahsan-javaiid force-pushed the fix/refresh-balance branch from 20d670c to c1b7136 Compare April 29, 2025 06:06

kvhnuke changed the base branch from develop to devop/packeupdates-0512 May 12, 2025 20:03

kvhnuke merged commit 5af58a9 into enkryptcom:devop/packeupdates-0512 May 12, 2025
2 of 3 checks passed

coderabbitai bot mentioned this pull request May 27, 2025

[FIX] Total balance not updated when withdrawal completes #701

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FIX] Total balance not updated when withdrawal completes #641

[FIX] Total balance not updated when withdrawal completes #641

Uh oh!

ahsan-javaiid commented Mar 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

ahsan-javaiid commented Mar 18, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

kvhnuke commented Apr 24, 2025

Uh oh!

ahsan-javaiid commented Apr 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[FIX] Total balance not updated when withdrawal completes #641

[FIX] Total balance not updated when withdrawal completes #641

Uh oh!

Conversation

ahsan-javaiid commented Mar 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Snapshots

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

ahsan-javaiid commented Mar 18, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

kvhnuke commented Apr 24, 2025

Uh oh!

ahsan-javaiid commented Apr 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ahsan-javaiid commented Mar 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 18, 2025 •

edited

Loading