EMQX-10974 heal partition once majority is alive #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeTupchiy
force-pushed
the
EMQX-10974-heal-partition-once-majority-is-alive
branch
from
a9919df
to
13b55d1
Compare
ieQu1
approved these changes
Jun 19, 2024
qzhuyan
reviewed
Jun 19, 2024
| is_majority_alive() -> | ||
| All = mria_mnesia:cluster_nodes(all), | ||
| NotAliveLen = length(All -- [node() | nodes()]), | ||
| NotAliveLen < (length(All) div 2). |
There was a problem hiding this comment.
Is it possible that length(ALL) = 1 but node() is not in All?
There was a problem hiding this comment.
This is called by a leader core node, so it's hard to imagine that node() is not a member of Mnesia cluster (thus not in All) 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.