fix(conf cli): don't crash when diffing missing key #13996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
20241014-m-fix-print-inconsist-mapget
branch
from
995a74a
to
bd9df1c
Compare
keynslug
approved these changes
Oct 16, 2024
| @@ -855,7 +857,7 @@ print_inconsistent_conf(New, Old, Options) -> | |||
| target := {Target, TargetTnxId}, | |||
| node := {Node, NodeTnxId} | |||
| } = Options, | |||
| emqx_ctl:print("~ts(tnx_id=~w)'s ~s is diff from ~ts(tnx_id=~w).~n", [ | |||
| emqx_ctl:print("~ts(tnx_id=~w)'s ~s is different from ~ts(tnx_id=~w).~n", [ | |||
There was a problem hiding this comment.
Nit / Q: Why is it tnx and not txn, which is a common abbreviation for transaction?
There was a problem hiding this comment.
Good question. I can only guess. Maybe who wrote this initially is not familiar with that convention, or it's a typo that got carried by copy-and-pasting. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-13004
Release version: v/e5.8.2
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update