Skip to content

feat(dssess): fix end of stream handling #13977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

savonarola
Copy link
Contributor

@savonarola savonarola commented Oct 10, 2024

Fixes EMQX-13251

The problem with end_of_stream seemed to be the following:

  • stream gets end_of_stream
  • it gets last seqno's set to first seqnos
    last_seqno_qos2 = FirstSeqnoQos2,
  • then it gets into to_U
  • to_U deletes keys from blocked sets by those last seqnos, thus removing other stream's data
  • this other stream falls out of the state machine

Release version: v/e5.8.2

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes (tests in platform failed)
  • For internal contributor: there is a jira ticket to track this change
  • Schema changes are backward compatible

@savonarola savonarola requested review from lafirest and a team as code owners October 10, 2024 14:37
@savonarola savonarola marked this pull request as draft October 10, 2024 14:37
@savonarola savonarola requested a review from ieQu1 October 10, 2024 14:43
@savonarola savonarola force-pushed the 1010-fix-end-of-stream-handling branch from fa31926 to 749da16 Compare October 10, 2024 16:20
@savonarola savonarola marked this pull request as ready for review October 10, 2024 16:25
@savonarola savonarola merged commit b5ffa89 into emqx:release-58 Oct 10, 2024
199 checks passed
@emqxqa
Copy link

emqxqa commented Oct 11, 2024

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants