feat(retainer): clean expired messages in separate process #13969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is expected to run only on a single node in a cluster at a time.
...Through forcing it to stop after specific (e.g. 50000) number of cleared retained messages.
keynslug
force-pushed
the
fix/EMQX-13213/retainer-gc
branch
from
41b46ce to
13fc313
Compare
As a hidden option for now.
keynslug
force-pushed
the
fix/EMQX-13213/retainer-gc
branch
from
13fc313 to
b5c8907
Compare
savonarola
reviewed
Oct 10, 2024
| deadline => erlang:system_time(millisecond), | ||
| limit => emqx_conf:get([retainer, msg_clear_limit], all) | ||
| }, | ||
| _Result = emqx_retainer_sup:start_gc(Context, Opts), |
There was a problem hiding this comment.
Should we monitor the process and not start the next iteration until the previous one is finished?
E.g. to avoid piling up the cleaners.
There was a problem hiding this comment.
Supervisor starts it under the same child id each time, so in this case _Result should be {error, {already_started, ...}} (appreciate a double-check of this claim).
savonarola
approved these changes
Oct 10, 2024
keynslug
added a commit
to keynslug/emqx
that referenced
this pull request
Oct 13, 2024
|
keynslug
added a commit
that referenced
this pull request
Oct 17, 2024
chore: add #13969 changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-13213.
Release version: v5.8.2
Summary
See individual commits.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Added property-based tests for code which performs user input validationchanges/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesCreated PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket