Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rule engine metrics): bump failed metric when its sub-counters are bumped #13916

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(rule engine metrics): bump failed metric when its sub-counters are bumped #13916

merged 1 commit into from
Oct 3, 2024

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Oct 2, 2024 •
edited
Loading

Fixes https://emqx.atlassian.net/browse/EMQX-13107

Release version: v/e5.8.2

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the 20241002-m-rule-runtime-failed-metrics branch from 9de78df to 148edfa Compare October 2, 2024 16:00
@thalesmg thalesmg marked this pull request as ready for review October 2, 2024 19:30
@thalesmg thalesmg requested review from kjellwinblad and a team as code owners October 2, 2024 19:30
@thalesmg thalesmg merged commit 6b3f0ce into emqx:master Oct 3, 2024
195 checks passed
@thalesmg thalesmg deleted the 20241002-m-rule-runtime-failed-metrics branch October 3, 2024 12:23
@emqxqa
Copy link

emqxqa commented Oct 22, 2024

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keynslug keynslug keynslug approved these changes

@kjellwinblad kjellwinblad Awaiting requested review from kjellwinblad kjellwinblad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thalesmg @emqxqa @keynslug