Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mgmt): correctly handle return of publish when persistent sessi… #13832

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix(mgmt): correctly handle return of publish when persistent sessi… #13832

merged 2 commits into from
Sep 23, 2024

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Sep 19, 2024 •
edited by zmstone
Loading

…ons are enabled

Fixes EMQX-12947

Release version: v/e5.8.1

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review September 20, 2024 02:56
@lafirest lafirest requested a review from a team as a code owner September 20, 2024 02:56
zmstone
zmstone requested changes Sep 21, 2024
View reviewed changes
Copy link
Member

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test case

@lafirest lafirest merged commit 8adc9e5 into emqx:release-58 Sep 23, 2024
195 checks passed
@lafirest lafirest deleted the fix/pub_ds branch September 23, 2024 09:49
@emqxqa
Copy link

emqxqa commented Sep 26, 2024

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJianBo HJianBo HJianBo approved these changes

@zmstone zmstone zmstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lafirest @emqxqa @zmstone @HJianBo