feat(quic): conn scope keepalive #13814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
force-pushed
the
dev/william/quic-conn-scope-keep-alive
branch
4 times, most recently
from
a19b372
to
edf88e5
Compare
zmstone
reviewed
Sep 20, 2024
apps/emqx/src/emqx_keepalive.erl
Outdated
| #{keepalive_multiplier := Mul, keepalive_check_interval := CheckInterval} = | ||
| emqx_config:get_zone_conf(Zone, [mqtt]), | ||
| MilliSeconds = timer:seconds(Second), | ||
| Interval = emqx_utils:clamp(CheckInterval, 1000, max(MilliSeconds div 2, 1000)), | ||
| MaxIdleMs = ceil(MilliSeconds * Mul), | ||
| {StatVal, ReaderFun} = | ||
| case is_function(Stat) of |
There was a problem hiding this comment.
use {M, F, A} tuple instead, otherwise badarg during hot-upgrade.
qzhuyan
force-pushed
the
dev/william/quic-conn-scope-keep-alive
branch
from
0e5d52d
to
857a89e
Compare
zmstone
approved these changes
Sep 21, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-13134
Intro a new feature for MQTT over QUIC multi-stream, called connection scope keepalive
We used to require the client to send MQTT.PINGREQ on idle control stream to keep the connection alive even when the data stream is active, this PR intro a conn shared state which has counters could be bumped by all the streams in the same connection, so the keepalive could read this shared counters to judge if conn is still alive.
This hopefully could further mitigate the keepalive timeout due to HOL blocking.
Release version: v/e5.?
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update