Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ws): websocket connection crash when stats are sent to $SYS topic #13754

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix(ws): websocket connection crash when stats are sent to $SYS topic #13754

merged 2 commits into from
Sep 3, 2024

Conversation

id
Copy link
Collaborator

@id id commented Sep 3, 2024 •
edited
Loading

fixes #13744
fixes #13780
fixes #13787

Release version: v/e5.8.1

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@id id requested review from lafirest and a team as code owners September 3, 2024 11:50
@id id merged commit 72828e3 into emqx:master Sep 3, 2024
194 of 196 checks passed
@id id deleted the 20240903-fix-websocket-conn-crash branch September 3, 2024 12:48
@id id mentioned this pull request Sep 9, 2024
Closed
prehor added a commit to prehor/home-ops that referenced this pull request Sep 12, 2024
@prehor
Revert "feat(container): update image public.ecr.aws/emqx/emqx ( 5.7.…
a8112bb 
…2 → 5.8.0 )"

This reverts commit 3a0ade5.

See emqx/emqx#13754
@prehor prehor mentioned this pull request Sep 12, 2024
Merged
1 task
@zmstone zmstone mentioned this pull request Sep 13, 2024
Closed
prehor added a commit to prehor/home-ops that referenced this pull request Sep 15, 2024
@prehor
Revert "feat(container): update image public.ecr.aws/emqx/emqx ( 5.7.…
8306e67 
…2 → 5.8.0 )"

This reverts commit 720f6ff.

See emqx/emqx#13754
@emqxqa
Copy link

emqxqa commented Sep 20, 2024

TestExecution

@emqxqa
Copy link

emqxqa commented Sep 20, 2024

TestExecution

@prehor prehor mentioned this pull request Sep 20, 2024
Merged
1 task
@prehor prehor mentioned this pull request Oct 2, 2024
Merged
1 task
This was referenced Oct 7, 2024
Closed
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qzhuyan qzhuyan qzhuyan approved these changes

@lafirest lafirest Awaiting requested review from lafirest lafirest is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v5.8.0 WS connect kepp disconnect Befroe v5.7.2 is good. use image emqx:5 in20240909 websocket terminated due to fail in matching function
3 participants
@id @emqxqa @qzhuyan