Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authn): allow deleting an authenticator which failed to initialize #13678

Merged

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Aug 23, 2024

Release version: v/e5.8.0

Summary

Prior to this fix, if a authenticator is failed to get initialized when node boots up, it will be displayed on dashboard in "disconnected" state.
But when we try to delete it from dashboard, a "not found" error is returned.

This is because although the config exists, it was not actually added to the chain (failed to init).
After this fix, the deletion in from the chain is made idempotent, i.e. allow delete even if it's not on the chain already.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone force-pushed the 0823-fix-authenticator-delete-idempotence branch from 73f3519 to acaab95 Compare August 23, 2024 07:21
@zmstone zmstone force-pushed the 0823-fix-authenticator-delete-idempotence branch from acaab95 to 8d61458 Compare August 23, 2024 09:29
@zmstone zmstone marked this pull request as ready for review August 23, 2024 09:32
@zmstone zmstone requested review from JimMoen and a team as code owners August 23, 2024 09:32
@zmstone zmstone changed the title fix(authn): allow deleting a authenticator which is failed to initialize fix(authn): allow deleting an authenticator which is failed to initialize Aug 23, 2024
@zmstone zmstone changed the title fix(authn): allow deleting an authenticator which is failed to initialize fix(authn): allow deleting an authenticator which failed to initialize Aug 23, 2024
@zmstone zmstone merged commit 60c175c into emqx:release-58 Aug 23, 2024
185 checks passed
@zmstone zmstone deleted the 0823-fix-authenticator-delete-idempotence branch August 23, 2024 12:25
@emqxqa
Copy link

emqxqa commented Aug 24, 2024

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants