fix(authn): allow deleting an authenticator which failed to initialize #13678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release version: v/e5.8.0
Summary
Prior to this fix, if a authenticator is failed to get initialized when node boots up, it will be displayed on dashboard in "disconnected" state.
But when we try to delete it from dashboard, a "not found" error is returned.
This is because although the config exists, it was not actually added to the chain (failed to init).
After this fix, the deletion in from the chain is made idempotent, i.e. allow delete even if it's not on the chain already.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update