feat: store certs not in mutable dir #13597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
reviewed
Aug 11, 2024
zmstone
reviewed
Aug 11, 2024
The dir stores certs files when the plugin calling `emqx_plugins:ensure_ssl_files/2,3`.
`emqx_tls_lib:ensure_ssl_files/2,3` -> `emqx_tls_lib:ensure_ssl_files_in_mutable_certs_dir/2,3` - The function always try ensure the ssl files in `data/certs` dir
- May fail due to file/path permissions issues
emqx_tls_lib:ensure_ssl_files_in_mutable_certs_dir/2,3 and emqx_tls_lib:ensure_ssl_files/2,3 should gen filename by given dir
JimMoen
force-pushed
the
feat-certs-not-in-mutable-dir
branch
from
872ea85 to
bcdb447
Compare
JimMoen
force-pushed
the
feat-certs-not-in-mutable-dir
branch
from
b7b840e to
0e51a5e
Compare
JimMoen
requested review from
a team,
SergeTupchiy and
lafirest
as code owners
JimMoen
changed the title
zmstone
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-12834
Release version: v/e5.8.0
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update