chore: upgrade to gen_rpc-3.4.0 #13493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gen_rpc 3.4.0 introduced {active,100} by default for acceptor socket.
which should pose some push-backs towards RPC caller nodes
when it's uner heavy load
zmstone
force-pushed
the
0719-upgrade-gen_rpc-to-3.4.0
branch
from
de79938 to
5d601dc
Compare
id
previously approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release version: v/e5.8.0
Summary
Upgrade RPC library
gen_rpcto 3.4.0The default RPC server socket option in
gen_rpc3.4.0 has been changed fromtruetoactive-100which should provide back-pressure towards peer nodes when the RPC server is under heavy load.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update