fix(resource manager): disentangle connector and channel health check frequencies #13442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
20240709-r57-decouple-connector-action-hc
branch
2 times, most recently
from
c2419f6 to
edaef83
Compare
thalesmg
force-pushed
the
20240709-r57-decouple-connector-action-hc
branch
from
edaef83 to
9f8a188
Compare
savonarola
reviewed
Jul 15, 2024
| #{ | ||
| pending := CPending0, | ||
| %% TODO: rm pending | ||
| %% pending := CPending0, |
There was a problem hiding this comment.
🙈
I wanted to remove it entirely from state initialization and type specs. I'll do that in a follow up, thanks!
savonarola
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-12674
Release version: v/e5.7.2
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update