Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(banned): add a bootstrap file for banned #13386

Merged
merged 2 commits into from
Jul 5, 2024
Merged

feat(banned): add a bootstrap file for banned #13386

merged 2 commits into from
Jul 5, 2024

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Jul 2, 2024

Fixes EMQX-12272

Release version: v/e5.?

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest force-pushed the feat/banned_boot_57 branch 2 times, most recently from b5de01f to 25e6f54 Compare July 2, 2024 03:41
@lafirest lafirest marked this pull request as ready for review July 2, 2024 05:48
@lafirest lafirest requested a review from a team as a code owner July 2, 2024 05:48
zhongwencool
zhongwencool reviewed Jul 3, 2024
View reviewed changes
apps/emqx/src/emqx_banned.erl Outdated Show resolved Hide resolved
rel/i18n/emqx_schema.hocon Outdated Show resolved Hide resolved
@lafirest lafirest merged commit aa84ca5 into emqx:release-57 Jul 5, 2024
180 checks passed
@lafirest lafirest deleted the feat/banned_boot_57 branch July 5, 2024 00:47
@emqxqa
Copy link

emqxqa commented Jul 5, 2024

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongwencool zhongwencool zhongwencool left review comments

@zmstone zmstone zmstone left review comments

@qzhuyan qzhuyan qzhuyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lafirest @emqxqa @zmstone @qzhuyan @zhongwencool