fix: gateway app must depends on all auth apps #13258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJianBo
force-pushed
the
fix-boot-order-for-gws
branch
from
2c45811
to
9e0b157
Compare
id
previously approved these changes
Jun 20, 2024
|
But gateway test case fails. |
HJianBo
force-pushed
the
fix-boot-order-for-gws
branch
from
9e0b157
to
d8e6c07
Compare
id
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EEC-1046
Release version: v/e5.7.1
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Added tests for the changesAdded property-based tests for code which performs user input validationChanged lines covered in coverage reportchanges/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesCreated PR to emqx-docs if documentation update is required, or link to a follow-up jira ticketSchema changes are backward compatibleChecklist for CI (.github/workflows) changes
If changed package build workflow, pass this action (manual trigger)changes/dir for user-facing artifacts update