Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authn): support ${cert_pem} placeholder #13229

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Jun 11, 2024

Fixes EMQX-12538

Release version: v/e5.7.1

Summary

Support ${cert_pem} placeholder in authn templates.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • [~] Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested review from JimMoen, a team and lafirest as code owners June 11, 2024 17:56
@zmstone zmstone changed the title feat(authn): support ${cert_pem} placeholder feat(authn): support ${cert_pem} placeholder Jun 11, 2024
@zmstone zmstone merged commit 51810c6 into emqx:release-57 Jun 11, 2024
178 checks passed
@zmstone zmstone deleted the 0611-auth-with-raw-cert branch June 11, 2024 19:16
@emqxqa
Copy link

emqxqa commented Jun 18, 2024

TestExecution

id added a commit to emqx/emqx-docs that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants