Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): redact sensitive data for the authn/authz APIs #13225

Merged
merged 2 commits into from
Jun 14, 2024
Merged

fix(auth): redact sensitive data for the authn/authz APIs #13225

merged 2 commits into from
Jun 14, 2024

Conversation

lafirest
Copy link
Member

Fixes EMQX-12512

Release version: v/e5.?

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review June 12, 2024 01:05
@lafirest lafirest requested review from JimMoen and a team as code owners June 12, 2024 01:05
zmstone
zmstone reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase it to release-57

@lafirest lafirest merged commit afd4b46 into emqx:master Jun 14, 2024
176 checks passed
@lafirest lafirest deleted the fix/mysql_redact branch June 14, 2024 01:19
@lafirest
Copy link
Member Author

Rebase it to release-57
This PR affects all backends of authz/authn, so we decided to put it in release-58

@emqxqa
Copy link

emqxqa commented Aug 12, 2024

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone left review comments

@zhongwencool zhongwencool zhongwencool approved these changes

@JimMoen JimMoen Awaiting requested review from JimMoen JimMoen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lafirest @emqxqa @zmstone @zhongwencool