Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource manager): force kill process if stuck when stopping/removing #13181

Merged

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Jun 4, 2024

Fixes https://emqx.atlassian.net/browse/EMQX-12357

Release version: v/e5.7.1

image

Summary

The original issue originated when the connector process (emqx_resource_manager) was stuck trying to start, and an API call to remove the action/source would arrive, timing out in a gen_statem:call.

Now, the recommended workaround in such situations is to first stop the connector before disabling/removing the action/source. Now, when stopping a connector, if the stop call times out, we forcefully kill the process.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the force-stop-connector-r57-20240604 branch from ba70f43 to f17aefe Compare June 4, 2024 15:05
@thalesmg thalesmg marked this pull request as ready for review June 4, 2024 16:39
@thalesmg thalesmg requested a review from a team as a code owner June 4, 2024 16:39
@thalesmg thalesmg merged commit ae0379f into emqx:release-57 Jun 5, 2024
174 checks passed
@thalesmg thalesmg deleted the force-stop-connector-r57-20240604 branch June 5, 2024 12:08
@emqxqa
Copy link

emqxqa commented Jun 10, 2024

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants