fix: trace formatter should not crash when given a non-binary payload #13140
Conversation
kjellwinblad
force-pushed
the
kjell/republish_trace_crash/EMQX-12474
branch
from
42ec8ab
to
2eb5c24
Compare
| emqx_packet:format(Packet, Encode) | ||
| catch | ||
| _:_ -> | ||
| %% We don't want to crash if there is a field named packet with |
There was a problem hiding this comment.
could you provide an example here?
There was a problem hiding this comment.
There is a trace that includes the output of a rule. As the the rule can output almost any map it can contain a field named packet. Not 100% sure if the key can be an atom in that case. Perhaps the optimal solution is to not look for the packet field in all levels of the map as we may only want to format it when it is in the top level. What do you think? The payload field is perhaps different since the user can change how it is formatted and will perhaps expect it to be formatted this way wherever it may be.
There was a problem hiding this comment.
this is ok.
I missed that this is done recursively.
maybe good to explain as comment.
It would not hurt. I added a task for this so I can pick it up later: https://emqx.atlassian.net/browse/EMQX-12483
Also does not hurt. Will try to add this at the same time as I do the task above. |
Fixes:
https://emqx.atlassian.net/browse/EMQX-12474
Release version: v/e5.?
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles