Skip to content

fix(ssl-clients): allow wildcard certificates by default #12962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented May 2, 2024

Fixes EMQX-12214

Release version: v/e5.7.0

Summary

Support wildcard certificates.
Tested manually with testing wildcard certificate issued to *.local.net.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone force-pushed the 0502-fix-ssl-client-opts-to-allow-wildcard-cert-by-default branch 2 times, most recently from d09cc46 to 1d38686 Compare May 3, 2024 08:30
@zmstone zmstone marked this pull request as ready for review May 3, 2024 08:36
@zmstone zmstone requested review from JimMoen, lafirest and a team as code owners May 3, 2024 08:36
keynslug
keynslug previously approved these changes May 3, 2024
@zmstone zmstone force-pushed the 0502-fix-ssl-client-opts-to-allow-wildcard-cert-by-default branch from 8ce1680 to 37d66e9 Compare May 3, 2024 10:52
@zmstone zmstone changed the base branch from master to release-57 May 3, 2024 11:02
@zmstone zmstone merged commit 5235774 into emqx:release-57 May 3, 2024
173 checks passed
@zmstone zmstone deleted the 0502-fix-ssl-client-opts-to-allow-wildcard-cert-by-default branch May 3, 2024 13:19
@emqxqa
Copy link

emqxqa commented May 8, 2024

Test Execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants