Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mgmt): add ignore_readonly to configs API #12940

Merged
merged 6 commits into from
Apr 29, 2024
Merged

feat(mgmt): add ignore_readonly to configs API #12940

merged 6 commits into from
Apr 29, 2024

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Apr 27, 2024 •
edited
Loading

Fixes EMQX-12258

Release version: v/e5.7.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone marked this pull request as ready for review April 27, 2024 19:20
@zmstone zmstone requested review from lafirest and a team as code owners April 27, 2024 19:20
zmstone added 2 commits April 28, 2024 14:05
@zmstone
chore: upgrade to hocon-0.42.2
10625ea 
hocon pretty-print quotes more string values
if a string has '.' or '-', or if it starts with a digit 0-9,
then it's quoted.

see details here: emqx/hocon#293
@zmstone
feat(mgmt): add ignore_readonly qeury-string to PUT /configs API
07cbdc6
@zmstone zmstone changed the title fix(mgmt): avoid 500 error when hocon syntax error feat(mgmt): add ignore_readonly to configs API Apr 28, 2024
@zmstone zmstone force-pushed the 0427-catch-hocon-syntax-error branch from 66d8317 to c3d2734 Compare April 28, 2024 13:06
keynslug
keynslug previously approved these changes Apr 29, 2024
View reviewed changes
apps/emqx_conf/src/emqx_conf_cli.erl Outdated Show resolved Hide resolved
keynslug
keynslug previously approved these changes Apr 29, 2024
View reviewed changes
changes/ce/feat-12940.en.md Outdated Show resolved Hide resolved
@zmstone zmstone force-pushed the 0427-catch-hocon-syntax-error branch from 9ec5865 to 1db932d Compare April 29, 2024 08:20
@zmstone zmstone merged commit a41652e into emqx:release-57 Apr 29, 2024
172 checks passed
@zmstone zmstone deleted the 0427-catch-hocon-syntax-error branch April 29, 2024 11:22
@Rory-Z Rory-Z mentioned this pull request May 10, 2024
Closed
@yanzhiemq
Copy link
Collaborator

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keynslug keynslug keynslug approved these changes

@lafirest lafirest Awaiting requested review from lafirest lafirest is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmstone @yanzhiemq @keynslug