Skip to content

fix(stats): 'subscribers.count' contains shared-subscriber #12765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented Mar 22, 2024

Fixes
https://emqx.atlassian.net/browse/EMQX-12043
https://emqx.atlassian.net/browse/EMQX-12056

Release version: v/e5.6.1

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • [ ] Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • [ ] If changed package build workflow, pass this action (manual trigger)
  • [ ] Change log has been added to changes/ dir for user-facing artifacts update

@JimMoen JimMoen force-pushed the EMQX-12043/subscribers-count branch from b97a5a9 to 5f7f9e4 Compare March 25, 2024 07:13
@JimMoen JimMoen marked this pull request as ready for review March 25, 2024 08:55
@JimMoen JimMoen requested review from lafirest and a team as code owners March 25, 2024 08:55
Comment on lines +267 to +270
%% m(
%% 'messages.retained',
%% <<"Number of retained messages">>
%% ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimMoen JimMoen merged commit 3e97e55 into emqx:master Mar 25, 2024
167 checks passed
@JimMoen JimMoen deleted the EMQX-12043/subscribers-count branch March 25, 2024 15:09
@emqxqa
Copy link

emqxqa commented May 8, 2024

Test Execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants