Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor MS SQL Server bridge to connector and action #12619

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented Mar 1, 2024

Fixes EMQX-11468

Release version: v/e5.6.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

@JimMoen JimMoen force-pushed the EMQX-11468/refactor/sqlserver branch 3 times, most recently from e80c9f8 to 140c49f Compare March 1, 2024 08:53
@JimMoen JimMoen marked this pull request as ready for review March 1, 2024 11:39
@JimMoen JimMoen requested review from lafirest and a team as code owners March 1, 2024 11:39
@JimMoen JimMoen changed the base branch from master to release-56 March 4, 2024 01:45
@JimMoen JimMoen force-pushed the EMQX-11468/refactor/sqlserver branch from 71b0e73 to 441b6f7 Compare March 4, 2024 09:14
@JimMoen JimMoen merged commit 3e7311e into emqx:release-56 Mar 4, 2024
163 of 165 checks passed
@JimMoen JimMoen deleted the EMQX-11468/refactor/sqlserver branch March 4, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants