feat: refactor HStreamDB bridge to connector and action #12512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also upgrades the hstreamdb_erl driver library and change the action/bridge to use the new hstreamdb_erl. Much of the code for the new API is copied from: https://github.com/emqx/emqx-enterprise/blob/be1a1604dd5c4c06ea6be15b702f35d9bdec48a7/lib-ee/emqx_rule_actions/src/emqx_backend_hstreamdb_actions.erl Fixes: https://emqx.atlassian.net/browse/EMQX-11458
kjellwinblad
force-pushed
the
kjell/refactor/hstreamdb/EMQX-11458
branch
from
8b1eda3
to
4e8dfb4
Compare
kjellwinblad
force-pushed
the
kjell/refactor/hstreamdb/EMQX-11458
branch
from
03bc2b5
to
0bf7a12
Compare
zmstone
reviewed
Feb 16, 2024
Thanks @zmstone for the suggestions Co-authored-by: Zaiming (Stone) Shi <[email protected]>
zmstone
approved these changes
Feb 19, 2024
HJianBo
reviewed
Feb 26, 2024
| @@ -1,15 +1,17 @@ | |||
| %%-------------------------------------------------------------------- | |||
| %-------------------------------------------------------------------- | |||
HJianBo
reviewed
Feb 26, 2024
| end. | ||
|
|
||
| client_options(Config = #{url := ServerURL, ssl := SSL}) -> | ||
| GRPCTimeout = maps:get(<<"grpc_timeout">>, Config, ?DEFAULT_GRPC_TIMEOUT), |
There was a problem hiding this comment.
GRPCTimeout = maps:get(grpc_timeout, Config, ?DEFAULT_GRPC_TIMEOUT),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also upgrades the hstreamdb_erl driver library and change the action/bridge to use the new hstreamdb_erl.
Much of the code for the new API is copied from:
https://github.com/emqx/emqx-enterprise/blob/be1a1604dd5c4c06ea6be15b702f35d9bdec48a7/lib-ee/emqx_rule_actions/src/emqx_backend_hstreamdb_actions.erl
Fixes:
https://emqx.atlassian.net/browse/EMQX-11458
Release version: v/e5.?
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles