perf(emqx_cm): use a dedicated pool for channel cleanup #12336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeTupchiy
force-pushed
the
EMQX-11743-dedicated-channel-cleanup-pool
branch
from
7e4b5f6 to
f70f834
Compare
SergeTupchiy
commented
Jan 16, 2024
| async_submit_to_pool(?POOL, Fun, Args). | ||
|
|
||
| -spec submit_to_pool(any(), task()) -> any(). | ||
| submit_to_pool(Pool, Task) -> |
There was a problem hiding this comment.
Note: added a new function with a distinct name to avoid having different semantics under the same function arity, which would look quite messy, e.g.:
async_submit(Fun, Args) when is_function(Fun) ->
async_submit(?POOL, Fun, Args);
async_submit(Pool, Task) ->
...
thalesmg
approved these changes
Jan 16, 2024
| @@ -353,10 +353,12 @@ test_stepdown_session(Action, Reason) -> | |||
| %% to sync with the pool workers. | |||
| %% The number of tasks should be large enough to ensure all workers have | |||
| %% the chance to work on at least one of the tasks. | |||
| flush_emqx_pool() -> | |||
| flush_emqx_cm_pool() -> | |||
There was a problem hiding this comment.
Nit: this seems almost identical to emqx_pool:flush_async_tasks/1?
There was a problem hiding this comment.
Indeed, replaced it with `emqx_pool:flush_async_tasks/1, thanks!
There was a problem hiding this comment.
Sorry, failed to push this fix 🙈 , will issue a follow-up PR..
This is to isolate channels cleanup from other async tasks (like routes cleanup), as channels cleanup can be quite slow under high network latency conditions. Fixes: EMQX-11743
SergeTupchiy
force-pushed
the
EMQX-11743-dedicated-channel-cleanup-pool
branch
from
f70f834 to
b472b56
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to isolate channels cleanup from other async tasks (like routes cleanup), as channels cleanup can be quite slow under high network latency conditions.
Fixes EMQX-11743
Release version: v/e5.?
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update