-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSIS Installer stuck at "Installing, please wait..." #4057
NSIS Installer stuck at "Installing, please wait..." #4057
Comments
Generally the only time I see this behavior is when an existing install has been deleted rather then explicitly uninstalled via Add Remove Programs or the uninstaller itself. |
Yes, the existing install was indeed deleted instead of being uninstalled properly, but the installer should be able to handle this fairly common situation and install it anyway or at least show some kind of error |
For whoever run into this situation, use CCleaner to manually remove the entry from Windows Program list. Then re-run the installer. For reference, see this page |
This is quite confusing for end users, is it able to force re-install new versions? |
We've also encountered with the exact same situation. After removing the app's folder manually, the installer kept hanging around nearly half of the process.
Even though it's supposed to be the expected behavior, it's not the case here. We could eliminate the issue by removing the so-called
It's quite cryptic why it actually works this way and I'm also not familiar with this whole registry system at all, but hopefully someone will find it useful until there's no explanation/ultimate solution for this issue. Please also refer to @kebugcheckex's comment. There's a URL which roughly explains how apps can be purged from the system. |
@develar This is a rather critical bug. Users who delete the app folder manually or with some weird tools cannot reinstall the app. Is this fixable with a custom NSIS script? |
Just ran into this, kind of surprised the installer is completely stuck on this... |
We have found that the issue was because of old registry key at This is worth noting that we didn't change the appId. it seems like the installer bug in some old version? We currently use electron-builder v22.1.0 |
This is the problematic commit, which caused breaking change: 7518aee I suggest developers to handle this situation in code so that users of |
OMG. This has worked. I don't know what I've actually done. |
Removing the old incorrect But this does not help when the app folder is manually deleted. |
My workarounds for this issue:
|
@o2genum could you explain how to use that workaround? I'm getting what appears to be this problem (though we haven't manually removed the files), but I don't understand how to debug or fix it. |
For future googlers, to addendum my previous comment: I created an
|
IMO this is pretty critical indeed. Tried to install an electron-based application, but our company policy didn't allow the installation at first. After it being allowed and me trying to install it again it got stuck due to this issue |
Something that helped me was running CCleaner as recommended by @kebugcheckex and then setting The default |
I never saw this issue with THIS IS A CRITICAL BUG |
Thanks, good to know. How do you handle this situation, as i assume all your other builds do feature the version number in the filename |
I just ran into this using |
@develar hey there, any official plans/workarounds for this? |
Any updates on this? This is reported very frequently from our users and we dislike telling them to manually remove a registry key.. |
We're having this problem too and it's very frustrating |
Nightmare issue remains a nightmare. I think the best part of this issue is probably the fact that the key name is lost, so the entry appears like |
I've just run into the freezing installer problem too. New to Joplin. Trying to re-install after the old directory got damaged. Seem to remember not being able to originally install it either, but finding an older version that did eventually install, so I assumed it was that. Back to today. Eventually found my way here via Google. Scanned the fix and searched "Joplin" in regedit) only found two entries. One under Removed (both) as suggested. So. It seems like a trivial fix to me.
Or am I missing something? Either way I think something needs to be done. Even down to a searchable error message or number to give people a clue as to what the problem is. Apart from that. It looks interesting, and I look forward to having a play with it. Don. |
Some of my users have been complaining about this issue, though I tried to explain how to manually delete the registry some of them don't feel comfortable in doing it themselves. We need a fix for this bug |
@Numbergod, this fix works when the install dir is removed entirely: The bug occurs when the uninstaller in the install directory is missing/damaged/fails for some reason. That fix works in most cases, except the most subtle ones when the uninstaller is present, but fails due to mysterious reasons. |
Thanks for that. But I've managed to install it last week. And the fix is useless to people unless they know why it's failed and can research the fix to find it. Which they can't at present as the installer "just stops" with no information as to why. As outlined above; I think coding a solution that looks for this issue before proceeding is the way to mark this bug as fixed, and help everyone in the future. Thanks for your assistance, but if the installer checked for, and fixed the issue, I would never have had to spend hours looking into this, fixing my copy, and attempting to get the issue resolved properly. I'm not sure how this isn't the completely obvious way to fix this issue? Anyway. Good luck with your project. I look forward to spending more time using it, than I currently have, trying to fix it. |
Hit the bug yet again. Google Could we get any comment on this very serious problem? |
@slapbox Sorry, my bad, with the latest electron-builder 22.8.0 issue persists indeed. I updated my electron-builder and it worked for me only onсу because they changed the |
Apparently, in assisted mode the installer is meant to get stuck until cancelled. It says "Installation Aborted" and "Setup was not completed successfully" and offers a "Cancel" button. |
@develar, I ran in to this too and #4057 (comment) resolved it for me. Are you interested in a PR to make this part of the default nsis install script? Happy to work on that. |
@amiller-gh Yes, PR is welcome. |
Do we have any sort of fix on the software side of this? Like a setting that can be changes in package.json? Im surprised this has been open for more than a year now. |
|
A user reported that if they manually removed the Project Clippi folder instead of uninstalling properly, they can no longer install or uninstall the application. Supposedly updating to 22.9.1 fixes this. More info: electron-userland/electron-builder#4057
A user reported that if they manually removed the Project Clippi folder instead of uninstalling properly, they can no longer install or uninstall the application. Supposedly updating to 22.9.1 fixes this. More info: electron-userland/electron-builder#4057
Package.json:
installer.nsh:
Installer gets successfully built but when executed gets stuck at "Installing, please wait..." forever
The text was updated successfully, but these errors were encountered: