fix(initializer): set electron version to be float in init step #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorsky
approved these changes
Apr 2, 2017
There was a problem hiding this comment.
Should we also change versions in https://github.com/electron-userland/electron-forge/blob/master/tmpl/_compilerc ?
Also, will fix babel/babel-preset-env#229 (comment) 👍
src/init/init-npm.js
Outdated
| @@ -73,7 +73,7 @@ export default async (dir, lintStyle) => { | |||
|
|
|||
| for (const profile of ['development', 'production']) { | |||
| const envTarget = content.env[profile]['application/javascript'].presets.find(x => x[0] === 'env'); | |||
| envTarget[1].targets.electron = electronPrebuilt.version; | |||
| envTarget[1].targets.electron = parseFloat(electronPrebuilt.version.split('.').slice(0, 2).join('.')); | |||
There was a problem hiding this comment.
just parseFloat(electronPrebuilt.version) will be enough?
There was a problem hiding this comment.
@yavorsky Afaik it only allows the major.minor syntax, not a patch version. Floats can only have one decimal point 👍
|
@yavorsky That tmpl file is overridden in the code I have changed in this commit 👍 No need to change that preset value as it never reaches a inited project. |
MarshallOfSound
force-pushed
the
babel-env-float
branch
from
355cc96 to
e0dbdb0
Compare
|
just for clarity 🙂 |
…, for completeness
malept
approved these changes
Apr 2, 2017
4 tasks
dsanders11
pushed a commit
that referenced
this pull request
Jan 14, 2023
fix: use the latest version of Forge v6 for Fiddle Forge actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
/cc @malept