Skip to content

feat: add transparency checking to nativeTheme #42862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codebytere merged 3 commits into from
Jul 24, 2024
Merged

feat: add transparency checking to nativeTheme #42862

codebytere merged 3 commits into from
Jul 24, 2024

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Jul 11, 2024

Description of Change

Closes #27910.
Refs https://issues.chromium.org/issues/40260615.

Adds a new property prefersReducedTransparency to nativeTheme, which indicates whether the user has chosen to reduce OS-level transparency via system accessibility settings.

Checklist

Release Notes

Notes: Added a new property prefersReducedTransparency to nativeTheme, which indicates whether the user has chosen to reduce OS-level transparency via system accessibility settings.

@codebytere codebytere added semver/minor backwards-compatible functionality target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch. labels Jul 11, 2024
@codebytere codebytere changed the title feat: add transparency checking to nativeTheme feat: add transparency checking to nativeTheme Jul 11, 2024
@samuelmaddock
Copy link
Member

samuelmaddock commented Jul 11, 2024

Should we deprecate the macOS-only systemPreferences.accessibilityDisplayShouldReduceTransparency() API in favor of this?

@codebytere
Copy link
Member Author

codebytere commented Jul 11, 2024 •
edited
Loading

Oh yeah good call! they map to the same thing but this API is cross-platform. Will do!

erickzhao
erickzhao approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere requested a review from a team as a code owner July 11, 2024 16:21
@codebytere
Copy link
Member Author

codebytere commented Jul 11, 2024

@samuelmaddock done!

samuelmaddock
samuelmaddock approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere force-pushed the support-transparency-nativetheme branch from d1cec3a to 51c7020 Compare July 12, 2024 09:19
jkleinsc
jkleinsc approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere force-pushed the support-transparency-nativetheme branch from 51c7020 to 5084455 Compare July 23, 2024 10:39
@codebytere codebytere merged commit 5669a40 into main Jul 24, 2024
@release-clerk
Copy link

release-clerk bot commented Jul 24, 2024

Release Notes Persisted

Added a new property prefersReducedTransparency to nativeTheme, which indicates whether the user has chosen to reduce OS-level transparency via system accessibility settings.

@codebytere codebytere deleted the support-transparency-nativetheme branch July 24, 2024 12:38
@trop
Copy link
Contributor

trop bot commented Jul 24, 2024

I was unable to backport this PR to "31-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/31-x-y PR should also be added to the "31-x-y" branch. label Jul 24, 2024
@trop
Copy link
Contributor

trop bot commented Jul 24, 2024

I was unable to backport this PR to "30-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/31-x-y needs-manual-bp/30-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels Jul 24, 2024
@trop trop bot mentioned this pull request Jul 24, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Jul 24, 2024

I have automatically backported this PR to "32-x-y", please check out #43024

@trop trop bot added in-flight/32-x-y merged/32-x-y PR was merged to the "32-x-y" branch. and removed target/32-x-y PR should also be added to the "32-x-y" branch. in-flight/32-x-y labels Jul 24, 2024
@codebytere codebytere mentioned this pull request Jul 31, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Jul 31, 2024

@codebytere has manually backported this PR to "31-x-y", please check out #43137

@codebytere codebytere mentioned this pull request Jul 31, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Jul 31, 2024

@codebytere has manually backported this PR to "30-x-y", please check out #43138

@trop trop bot added in-flight/30-x-y merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. and removed needs-manual-bp/30-x-y in-flight/30-x-y in-flight/31-x-y labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@miniak miniak Awaiting requested review from miniak

@dsanders11 dsanders11 Awaiting requested review from dsanders11

@alicelovescake alicelovescake Awaiting requested review from alicelovescake

+1 more reviewer

@erickzhao erickzhao erickzhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api-review/approved ✅ merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. merged/32-x-y PR was merged to the "32-x-y" branch. semver/minor backwards-compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Expose macOS accessibility preferences

5 participants

@codebytere @samuelmaddock @jkleinsc @erickzhao