Skip to content

feat: add navigationHistory.getEntryAtIndex(int index) method #41662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 3 commits into from
Apr 5, 2024
Merged

feat: add navigationHistory.getEntryAtIndex(int index) method #41662

jkleinsc merged 3 commits into from
Apr 5, 2024

Conversation

@alicelovescake
Copy link
Member

@alicelovescake alicelovescake commented Mar 22, 2024 •
edited by clavin
Loading

Backport of #41577

See that PR for details.

Notes: Added a new instance property navigationHistory on webContents API with navigationHistory.getEntryAtIndex method, enabling applications to retrieve the URL and title of any navigation entry within the browsing history.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 22, 2024
@trop trop bot added 30-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Mar 22, 2024
@trop trop bot mentioned this pull request Mar 22, 2024
Merged
10 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 22, 2024
@alicelovescake
Copy link
Member Author

alicelovescake commented Mar 26, 2024 •
edited
Loading

@MarshallOfSound @codebytere Trop doesn't tag reviewers for manual back ports so wanted to check if one of you can approve and help me merge this! Thanks in advance!

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Mar 26, 2024

@alicelovescake Both of these backports require WG Releases approval (see backport/requested label). We can approve them once that backport request is approved at the releases meeting tomorrow

@deepak1556
Copy link
Member

deepak1556 commented Mar 27, 2024

Can you update the PR with changes from #41705, thanks!

@alicelovescake
Copy link
Member Author

alicelovescake commented Mar 27, 2024 •
edited
Loading

Can you update the PR with changes from #41705, thanks!

@deepak1556 Thanks for the heads up! I realized I missed 1 more url so created a new PR #41706 on main to fix it. Sorry for the extra step! Appreciate you taking a quick look!

ps. I've just updated both my backports with the newest changes so they are both ready to go once the PR merges.

@alicelovescake alicelovescake force-pushed the manual-bp/alicelovescake/pr/41577/branch/30-x-y branch from 042c832 to 2bc7b2e Compare April 4, 2024 17:48
@jkleinsc jkleinsc merged commit 9056dd7 into electron:30-x-y Apr 5, 2024
@release-clerk
Copy link

release-clerk bot commented Apr 5, 2024

No Release Notes

@trop trop bot requested a review from a team April 12, 2024 22:56
@dsanders11 dsanders11 mentioned this pull request Apr 23, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@clavin clavin clavin approved these changes

Assignees

No one assigned

Labels

30-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alicelovescake @MarshallOfSound @deepak1556 @jkleinsc @clavin