chore: bump chromium to 125.0.6412.0 (main) #41610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![electron-roller[bot]](https://avatars.githubusercontent.com/in/115177?s=60&v=4){kind=small}
electron-roller
bot
changed the title
electron-roller
bot
changed the title
jkleinsc
added
target/30-x-y
electron-roller
bot
changed the title
electron-roller
bot
changed the title
jkleinsc
added
no-backport
and removed
target/30-x-y
electron-roller
bot
changed the title
electron-roller
bot
changed the title
electron-roller
bot
changed the title
electron-roller
bot
changed the title
electron-roller
bot
changed the title
electron-roller
bot
changed the title
clavin
force-pushed
the
roller/chromium/main
branch
from
c9d65fe
to
ebbad58
Compare
electron-roller
bot
changed the title
electron-roller
bot
changed the title
electron-roller
bot
changed the title
electron-roller
bot
changed the title
electron-roller
bot
changed the title
electron-roller
bot
changed the title
electron-roller
bot
changed the title
electron-roller
bot
changed the title
deepak1556
force-pushed
the
roller/chromium/main
branch
from
c33a4d9
to
12d8e7b
Compare
deepak1556
reviewed
Apr 12, 2024
accidental bump to 1.2.5 revealed failing app.setasdefaultprotocolclient test suite. Should be revisited separately.
deepak1556
reviewed
Apr 12, 2024
| @@ -2291,6 +2291,7 @@ jobs: | |||
| <<: *env-stack-dumping | |||
| parallelism: 2 | |||
| steps: | |||
| - run: nvm install lts/iron && nvm alias default lts/iron | |||
There was a problem hiding this comment.
@MarshallOfSound we need Node >= 18 for our test dependencies, https://app.circleci.com/pipelines/github/electron/electron/80090/workflows/eb28bb2e-3618-46aa-ab0a-2d45f4cd34a4/jobs/1699689. Added this temporary to unblock the roll.
ckerr
reviewed
Apr 15, 2024
spec/package.json
Outdated
| @@ -44,6 +44,7 @@ | |||
| "resolutions": { | |||
| "nan": "file:../../third_party/nan", | |||
| "dbus-native/optimist/minimist": "1.2.7", | |||
| "dbus-native/xml2js": "0.5.0" | |||
| "dbus-native/xml2js": "0.5.0", | |||
| "abstract-socket": "github:deepak1556/node-abstractsocket#121d94ca6d1811f90cd035e9787aaea79b5cf533" | |||
There was a problem hiding this comment.
tldr for reviewers: moves from nan to napi
There was a problem hiding this comment.
Given the module was used for test only, this was the faster route to unblock the roll also avoids any future breakage :)
ckerr
approved these changes
Apr 15, 2024
jkleinsc
requested changes
Apr 15, 2024
There was a problem hiding this comment.
patches/chromium/mas_avoid_private_macos_api_usage.patch.patch adds back code that was removed in https://chromium-review.googlesource.com/c/chromium/src/+/5348565. Looks like it was an inadvertent change that happened while updating the patches
Removed code that was inadvertently put back after https://chromium-review.googlesource.com/c/chromium/src/+/5348565 removed it
|
restarting build-linux after apparent CI flake:
|
jkleinsc
approved these changes
Apr 15, 2024
|
Release Notes Persisted
|
3 tasks
codebytere
pushed a commit
that referenced
this pull request
Jul 25, 2024
* chore: in shell/renderer/renderer_client_base.h, remove include media/base/key_systems_support_registration.h last use removed in c670e38 (##41610) * chore: iwyu electron/fuses.h * chore: iwyu media/base/video_frame.h * chore: iwyu base/functional/callback.h * chore: iwyu base/task/cancelable_task_tracker.h * chore: iwyu shell/browser/draggable_region_provider.h * chore: iwyu shell/browser/ui/inspectable_web_contents_view.h * chore: iwyu ui/aura/window.h * chore: iwyu ui/base/win/shell.h * chore: iwyu ui/display/win/screen_win.h * chore: iwyu ui/gfx/geometry/insets.h * chore: iwyu ui/display/display.h * chore: iwyu ui/gfx/geometry/skia_conversions.h * chore: iwyu ui/gfx/geometry/rect_conversions.h * chore: iwyu ui/gfx/geometry/point.h * chore: iwyu ui/gfx/scoped_canvas.h * chore: iwyu ui/gfx/image/image.h * chore: iwyu ui/accessibility/ax_node_data.h * chore: iwyu ui/views/animation/ink_drop_highlight.h * chore: iwyu ui/gfx/font_list.h * chore: iwyu ui/linux/nav_button_provider.h * chore: iwyu shell/browser/ui/views/frameless_view.h * chore: iwyu services/metrics/public/cpp/ukm_source_id.h * chore: iwyu net/http/http_util.h * chore: iwyu net/base/mime_util.h * chore: iwyu content/public/common/content_client.h * chore: iwyu <list> * chore: iwyu <optional> * chore: iwyu <memory> * chore: iwyu base/files/file_path.h * chore: iwyu ui/base/cursor/cursor.h * chore: iwyu build/build_config.h * chore: iwyu content/public/browser/web_contents.h * chore: iwyu shell/browser/hid/hid_chooser_context.h * chore: iwyu shell/common/platform_util.h * chore: iwyu base/task/single_thread_task_runner.h * chore: iwyu content/browser/renderer_host/render_widget_host_impl.h * chore: iwyu content/public/browser/render_widget_host.h * chore: iwyu shell/browser/electron_browser_context.h * chore: iwyu content/public/browser/web_contents_observer.h * chore: iwyu content/public/browser/render_frame_host.h * chore: iwyu content/public/browser/media_stream_request.h * chore: iwyu chrome/common/chrome_paths.h * chore: iwyu chrome/browser/icon_manager.h * chore: iwyu printing/print_settings.h * chore: iwyu renderer/pepper_helper.h * chore: iwyu shell/browser/api/process_metric.h * chore: iwyu shell/browser/electron_browser_client.h * chore: iwyu shell/browser/electron_browser_context.h * chore: iwyu shell/browser/api/electron_api_session.h * chore: iwyu shell/browser/api/electron_api_app.h * chore: iwyu shell/browser/ui/views/client_frame_view_linux.h * chore: iwyu shell/browser/native_window_views.h * chore: iwyu base/win/windows_version.h * chore: iwyu shell/common/electron_paths.h * chore: iwyu content/public/common/content_switches.h * chore: iwyu third_party/skia/include/core/SkRRect.h * chore: iwyu third_party/skia/include/core/SkBitmap.h * chore: iwyu third_party/skia * chore: iwyu shell/browser/osr/osr_host_display_client.h * chore: iwyu shell/browser/login_handler.h * chore: iwyu shell/browser/javascript_environment.h * chore: iwyu shell/browser/event_emitter_mixin.h * fix: mac * fix: mac * chore: iwyu base/nix/xdg_util.h * fix: win * fix: win * fix: win * fix: win
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Chromium to 125.0.6412.0.
See all changes in 124.0.6359.0..125.0.6412.0
Notes: Updated Chromium to 125.0.6412.0.