feat: add BrowserWindow.isOccluded()
#38982
Merged
+89
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-is-visible-check
branch
from
9745609 to
75bbfb1
Compare
codebytere
force-pushed
the
fix-is-visible-check
branch
from
75bbfb1 to
b7a56ee
Compare
codebytere
changed the title
BrowserWindow.isVisible() with occlusion on macOSBrowserWindow.isOccluded()
codebytere
force-pushed
the
fix-is-visible-check
branch
from
b7a56ee to
5a29680
Compare
codebytere
force-pushed
the
fix-is-visible-check
branch
from
5a29680 to
759f1e8
Compare
codebytere
added
semver/minor
codebytere
requested review from
MarshallOfSound,
VerteDinde,
miniak and
zcbenz
and removed request for
VerteDinde,
jkleinsc,
miniak and
zcbenz
ckerr
approved these changes
Feb 1, 2024
3 tasks
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "26-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "25-x-y" cleanly; |
trop
bot
removed
the
target/26-x-y
Contributor
|
I was unable to backport this PR to "27-x-y" cleanly; |
trop
bot
added
needs-manual-bp/26-x-y
and removed
target/25-x-y
Contributor
|
I was unable to backport this PR to "28-x-y" cleanly; |
trop
bot
added
needs-manual-bp/25-x-y
needs-manual-bp/27-x-y
needs-manual-bp/28-x-y
and removed
target/27-x-y
Contributor
|
I have automatically backported this PR to "29-x-y", please check out #41249 |
trop
bot
added
in-flight/29-x-y
and removed
target/29-x-y
6 tasks
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #38955.
We've historically not been consistent in our implementations of
BrowserWindow.isVisible()and similar methods how occlusion affects return values. I believe instead it might be more effective to add in a separate method for apps to check occlusion status.This also removes the occlusion check from the macOS implementation of
BrowserWindow.isVisible(), which was broken and not being properly accounted for.Checklist
npm testpassesRelease Notes
Notes: Added a new method
BrowserWindow.isOccluded()to allow apps to check occlusion status.