feat: update app.{set|get}LoginItemSettings(settings)
#37244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
support-smappservice
branch
7 times, most recently
from
03e8bcf to
8e60529
Compare
3 tasks
kyleshay
reviewed
Feb 15, 2023
kyleshay
reviewed
Feb 15, 2023
Member
Author
|
Note: macOS is failing becuase it needs a more recent SDK. Chromium has updated it upstream already, so this will be fixed as soon as https://github.com/electron/electron/pull/37130/files#diff-920de4a8729bdf120a0908a0f013f2e3a0e7c40acf0fdc961bbff77ca9106929L57 lands and this can be rebased. |
3 tasks
codebytere
force-pushed
the
support-smappservice
branch
from
8e60529 to
7dbbe44
Compare
electron-cation
bot
added
new-pr 🌱
Contributor
|
Is this blocked by something, @codebytere? |
codebytere
force-pushed
the
support-smappservice
branch
from
7dbbe44 to
1754e51
Compare
codebytere
force-pushed
the
support-smappservice
branch
from
1754e51 to
cc0e82b
Compare
erickzhao
reviewed
Jun 14, 2023
codebytere
force-pushed
the
support-smappservice
branch
from
cc0e82b to
065195c
Compare
VerteDinde
approved these changes
Sep 26, 2023
Member
VerteDinde
left a comment
VerteDinde
left a comment
There was a problem hiding this comment.
LGTM - test failures are unrelated
jkleinsc
reviewed
Sep 27, 2023
codebytere
force-pushed
the
support-smappservice
branch
4 times, most recently
from
1318fd3 to
ef3b84e
Compare
jkleinsc
reviewed
Sep 29, 2023
jkleinsc
reviewed
Sep 29, 2023
codebytere
force-pushed
the
support-smappservice
branch
from
9ceb66e to
7170b5c
Compare
jkleinsc
approved these changes
Oct 16, 2023
|
Release Notes Persisted
|
felixrieseberg
pushed a commit
to felixrieseberg/electron
that referenced
this pull request
Oct 25, 2023
* feat: update app.{set|get}LoginItemSettings(settings)
* test: fixup and add tests
* docs: add type link
* chore: name -> serviceName
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* feat: update app.{set|get}LoginItemSettings(settings)
* test: fixup and add tests
* docs: add type link
* chore: name -> serviceName
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37560.
Refs #37228
Refs electron/governance#533
This PR updated
app.setLoginItemSettings(settings)andapp.getLoginItemSettings(settings)on macOS 13 to use a single streamlined underlying API on both Mac App Store and regular macOS builds. This will remove several configuration and settings options, includingopenAsHiddeninapp.setLoginItemSettingsandwasOpenedAtLoginandwasOpenedAsHiddeninapp.getLoginItemSettings.This simplifies the underlying logic in accordance to the APIs apple has outlined for usage and improve parity between MAS and non-MAS builds. This will also allow developers to register app service objects, launch daemons, and login item services to launch on startup.
Checklist
npm testpassesRelease Notes
Notes: Migrated
app.{set|get}LoginItemSettings(settings)to use Apple's new recommended underlying framework on macOS.