-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add webContents.getPrintersAsync()
#31023
feat: add webContents.getPrintersAsync()
#31023
Conversation
77dd7ce
to
b3e2ea2
Compare
webContents.getPrintersAsync()
webContents.getPrinters()
3177381
to
4d785ae
Compare
webContents.getPrinters()
webContents.getPrintersAsync()
4d785ae
to
deaf392
Compare
deaf392
to
297d8a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, left some additional reviews.
eabe270
to
e08e1b6
Compare
9877715
to
d2b04e4
Compare
It is crashing on Windows:
|
9ebf849
to
1861134
Compare
1861134
to
5063ba8
Compare
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
5063ba8
to
1fe9f19
Compare
@zcbenz the crash has been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API looks good to me.
webContents.getPrintersAsync()
webContents.getPrintersAsync()
fix ci
webContents.getPrintersAsync()
fix ciwebContents.getPrintersAsync()
API LGTM |
Merging as CI failure is known flake already resolved. |
Release Notes Persisted
|
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
Description of Change
This deprecates the synchronous and blocking
webContents.getPrinters()
function and introduces
webContents.getPrintersAsync()
, which isasynchronous and non-blocking.
Signed-off-by: Darshan Sen [email protected]
cc @deepak1556 @nornagon
Checklist
npm test
passesRelease Notes
Notes: Deprecates
webContents.getPrinters()
and introduceswebContents.getPrintersAsync()