[Inference API] Use dimensions field in JinaAI text_embedding requests #139413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dimensions field was parsed from the service settings but never used. This commit includes the dimensions field in text embedding requests sent to JinaAI.
elasticsearchmachine
added
needs:triage
DonalEvans
added
>bug
auto-backport
Collaborator
|
Hi @DonalEvans, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
elasticsearchmachine
removed
needs:triage
jonathan-buttner
approved these changes
Dec 12, 2025
| builder = commonSettings.toXContentFragment(builder, params); | ||
| toXContentFragmentOfExposedFields(builder, params); | ||
|
|
||
| if (similarity != null) { |
Contributor
There was a problem hiding this comment.
How about we move similarity and maxInputTokens to toXContentFragmentOfExposedFields
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
DonalEvans
added a commit
to DonalEvans/elasticsearch
that referenced
this pull request
Dec 15, 2025
elastic#139413) The dimensions field was parsed from the service settings but never used. This commit includes the dimensions field in text embedding requests sent to JinaAI when set by the user. * Add dimensions_set_by_user to JinaAIEmbeddingsServiceSettings * Move similarity and max_input_tokens to exposed fields (cherry picked from commit b2ecf87) # Conflicts: # server/src/main/resources/transport/upper_bounds/9.3.csv # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntity.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/embeddings/JinaAIEmbeddingsServiceSettingsTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntityTests.java
DonalEvans
added a commit
to DonalEvans/elasticsearch
that referenced
this pull request
Dec 15, 2025
elastic#139413) The dimensions field was parsed from the service settings but never used. This commit includes the dimensions field in text embedding requests sent to JinaAI when set by the user. * Add dimensions_set_by_user to JinaAIEmbeddingsServiceSettings * Move similarity and max_input_tokens to exposed fields (cherry picked from commit b2ecf87) # Conflicts: # server/src/main/resources/transport/upper_bounds/9.3.csv # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntity.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/embeddings/JinaAIEmbeddingsServiceSettingsTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntityTests.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
parkertimmins
pushed a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Dec 17, 2025
elastic#139413) The dimensions field was parsed from the service settings but never used. This commit includes the dimensions field in text embedding requests sent to JinaAI when set by the user. * Add dimensions_set_by_user to JinaAIEmbeddingsServiceSettings * Move similarity and max_input_tokens to exposed fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dimensions field was parsed from the service settings but never used. This commit includes the dimensions field in text embedding requests sent to JinaAI.