Add upgrade.rollbacks mapping to .fleet-agents system index #139363
Conversation
elasticsearchmachine
added
v9.3.0
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @pchila, I've created a changelog YAML for you. |
| "type": "date" | ||
| }, | ||
| "version": { | ||
| "type": "text", |
There was a problem hiding this comment.
do we need both text and keyword type? Isn't it enough to have keyword?
There was a problem hiding this comment.
I used the same definition for version used elsewhere in the mappings.
I also think that keyword may be enough but I thought that the text mapping was there for a good reason.
There was a problem hiding this comment.
I'm not aware of a reason, but I suppose it's okay to make it consistent with other version fields.
There was a problem hiding this comment.
After discussing offline with @jillguyonnet about her comment, we came to the conclusion that it's worth trying to map field version as type: version.
She's going to run some tests and update the PR based on the outcome.
In case type: version doesn't work out, we can always go for type: keyword as suggested by @juliaElastic
|
Looks like I accidentally made my comment part of a pending review and it wasn't showing in the thread 🙈
I don't have any strong objections to text+keyword, version seems a bit cleaner though. |
ebeahan
added
>bug
v9.3.0
auto-backport
|
Hi @pchila, I've updated the changelog YAML for you. |
|
Hi @pchila, I've updated the changelog YAML for you. |
|
Tested version type for version field, it seems to behave well including with IAR versioning. |
|
@elasticmachine merge upstream |
…139363) * Add upgrade.rollbacks mapping to .fleet-agents system index * Update docs/changelog/139363.yaml * Update docs/changelog/139363.yaml * Update docs/changelog/139363.yaml * Change version field type to version --------- Co-authored-by: Eric Beahan <[email protected]> Co-authored-by: jillguyonnet <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
💚 Backport successful
|
…#139993) * Add upgrade.rollbacks mapping to .fleet-agents system index * Update docs/changelog/139363.yaml * Update docs/changelog/139363.yaml * Update docs/changelog/139363.yaml * Change version field type to version --------- Co-authored-by: Eric Beahan <[email protected]> Co-authored-by: jillguyonnet <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
6 participants
As follow-up to new rollback information managed by fleet-server with elastic/fleet-server#5975 this PR adds the mapping of the new fields to
.fleet-agentssystem index.Resolves elastic/fleet-server#6039