Skip to content

Conversation

@koooosh
Copy link
Contributor

@koooosh koooosh commented Nov 18, 2024

Description

Small error I found while looking through managed nodegroups documentation. The current codeblock comment is copied from the one above giving an example of unmanaged and managed nodegroups instead of referring to custom options for nodegroups.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello koooosh 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@cPu1 cPu1 added the kind/docs User documentation label Dec 2, 2024
@cPu1 cPu1 enabled auto-merge December 2, 2024 09:56
@cPu1 cPu1 merged commit 60f79c0 into eksctl-io:main Dec 2, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/docs User documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants