Match autosync payee #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Closing & re-opening to trigger travis build. |
|
Closing and re-opening to trigger is not necessary, as you have write access to this repository. From the travis page targetted by "Details" for the job, there is a "Restart Job" button. |
Owner
|
@kotp Good to know, thanks! |
501st-alpha1
force-pushed
the
match-autosync-payee
branch
from
1b0070c to
085bb35
Compare
501st-alpha1
force-pushed
the
match-autosync-payee
branch
from
085bb35 to
a4e02a4
Compare
`self.lgr` can be `None`, particularly during tests.
Contributor
Author
|
@egh I've rebased this onto |
Owner
|
@501st-alpha1 Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at implementing payee matching for #25. I've implemented it for the plain Ledger interface, and haven't (yet) done so for the Python interface or HLedger. (I've been having some trouble getting the Python interface to work with ledger-autosync, and I haven't gotten around to installing HLedger yet.) I added non-fatal stub functions for those two so that it's backwards-compatible at least.
If you're okay with the stubs and want to merge this as is, feel free, otherwise I can try to implement those too.