Add argument to specify ofxclient config file #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This looks good. My only hesitation would be that we might want to set up our own config file at some point, so maybe using |
Might want to add ledger-autosync config file eventually. egh#58 (comment)
Contributor
Author
|
Yes that makes sense, and your suggestion sounds good. I've pushed another commit for that; let me know if you'd rather I squash them down into a single commit. |
Owner
|
Looks good to me! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have separate
ofxclient.inifiles for my business vs. personal accounts, and I got tired of renaming them back and forth, so I've adding a command-line argument allowing me to specify which one I want to use. (This will also let me store the files elsewhere and have one less thing in$HOME.)Let me know if you'd like me to add a test for this, or if you have any other suggestions.