Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wgpu requirement from 0.15 to 0.19 #150

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 2, 2024

Updates the requirements on wgpu to permit the latest version.

Release notes

Sourced from wgpu's releases.

v0.19.3

This release includes wgpu, wgpu-core, and wgpu-hal. All other crates are unchanged.

Major Changes

Vendored WebGPU Bindings from web_sys

--cfg=web_sys_unstable_apis is no longer needed in your RUSTFLAGS to compile for WebGPU!!!

While WebGPU's javascript api is stable in the browsers, the web_sys bindings for WebGPU are still improving. As such they are hidden behind the special cfg --cfg=web_sys_unstable_apis and are not available by default. Everyone who wanted to use our WebGPU backend needed to enable this cfg in their RUSTFLAGS. This was very inconvenient and made it hard to use WebGPU, especially when WebGPU is enabled by default. Additionally, the unstable APIs don't adhere to semver, so there were repeated breakages.

To combat this problem we have decided to vendor the web_sys bindings for WebGPU within the crate. Notably we are not forking the bindings, merely vendoring, so any improvements we make to the bindings will be contributed directly to upstream web_sys.

By @​cwfitzgerald in #5325.

Bug Fixes

General

  • Fix an issue where command encoders weren't properly freed if an error occurred during command encoding. By @​ErichDonGubler in #5251.

Android

Changelog

Sourced from wgpu's changelog.

v0.19.3 (2024-03-01)

Major Changes

Vendored WebGPU Bindings from web_sys

--cfg=web_sys_unstable_apis is no longer needed in your RUSTFLAGS to compile for WebGPU!!!

While WebGPU's javascript api is stable in the browsers, the web_sys bindings for WebGPU are still improving. As such they are hidden behind the special cfg --cfg=web_sys_unstable_apis and are not available by default. Everyone who wanted to use our WebGPU backend needed to enable this cfg in their RUSTFLAGS. This was very inconvenient and made it hard to use WebGPU, especially when WebGPU is enabled by default. Additionally, the unstable APIs don't adhere to semver, so there were repeated breakages.

To combat this problem we have decided to vendor the web_sys bindings for WebGPU within the crate. Notably we are not forking the bindings, merely vendoring, so any improvements we make to the bindings will be contributed directly to upstream web_sys.

By @​cwfitzgerald in #5325.

Bug Fixes

General

  • Fix an issue where command encoders weren't properly freed if an error occurred during command encoding. By @​ErichDonGubler in #5251.

Android

v0.19.2 (2024-02-29)

Added/New Features

General

OpenGL

wgsl-out

  • Learned to generate acceleration structure types. By @​JMS55 in #5261

Documentation

  • Fix link in wgpu::Instance::create_surface documentation. By @​HexoKnight in #5280.
  • Fix typo in wgpu::CommandEncoder::clear_buffer documentation. By @​PWhiddy in #5281.
  • Surface configuration incorrectly claimed that wgpu::Instance::create_surface was unsafe. By @​hackaugusto in #5265.

Bug Fixes

General

  • Device lost callbacks are invoked when replaced and when global is dropped. By @​bradwerth in #5168
  • Fix performance regression when allocating a large amount of resources of the same type. By @​nical in #5229
  • Fix docs.rs wasm32 builds. By @​cwfitzgerald in #5310
  • Improve error message when binding count limit hit. By @​hackaugusto in #5298
  • Remove an unnecessary clone during GLSL shader injestion. By @​a1phyr in #5118.
  • Fix missing validation for Device::clear_buffer where offset + size > buffer.size was not checked when size was omitted. By @​ErichDonGubler in #5282.

... (truncated)

Commits
  • 9f505e7 Versions
  • 75fd689 wgpu-hal: add ndk-sys dependency to fix linking error. (#5326)
  • bb09828 Vendor WebGPU Bindings from web_sys (#5325)
  • d189cf2 fix: discard cmd. enc. buf. on wgpu_core::Global::command_encoder_drop
  • be8c7e6 fix(gles): discard cmd. enc. buf. on drop
  • 45ef175 fix(dx12): discard cmd. enc. buf. on drop
  • 61d779d Versions
  • f8355a8 [wgpu-hal.gles] Error log for failed GLES heuristics (#5266)
  • 7214da6 Fix missing validation for Device::clear_buffer where `offset + size > buff...
  • c27f743 Avoid a clone when creating a Glsl shader (#5118)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [wgpu](https://github.com/gfx-rs/wgpu) to permit the latest version.
- [Release notes](https://github.com/gfx-rs/wgpu/releases)
- [Changelog](https://github.com/gfx-rs/wgpu/blob/v0.19.3/CHANGELOG.md)
- [Commits](gfx-rs/wgpu@v0.15.0...v0.19.3)

---
updated-dependencies:
- dependency-name: wgpu
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 2, 2024
@ebkalderon
Copy link
Owner

Seems this is failing due to the triangle example no longer compiling. Fixing this isn't exactly a priority for getting the next release out, so this will wait until afterwards.

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 29, 2024

Superseded by #155.

@dependabot dependabot bot closed this Apr 29, 2024
@dependabot dependabot bot deleted the dependabot/cargo/wgpu-0.19 branch April 29, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant