Fix pinball BCs #132
Closed
Fix pinball BCs #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ludgerpaehler any idea why the CI test for black is failing on "/github/workspace/docs/conf.py"? |
nzolman
reviewed
Feb 19, 2024
examples/pinball/run-transient.py
Outdated
| restart = None | ||
| checkpoint = "checkpoint-coarse.h5" | ||
|
|
||
| flow = hgym.Pinball(Re=10, h5_file=restart, mesh="coarse") |
There was a problem hiding this comment.
Are we still using the hf_file kwarg? I thought I had seen that checkpoints are loaded with the restart keyword. https://github.com/dynamicslab/hydrogym/blob/main/hydrogym/core.py#L54
There was a problem hiding this comment.
Thanks, good catch. I copy-pasted from the demo script, which is also out of date.
|
Just finishing off KoopmanRL, will begin to review later s.t. we get everything aligned |
Never mind - this got missed in my formatting calls for some reason. Should be okay now. |
Closed
|
Closing - code was merged in #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the derivation of boundary conditions for flows with multiple actuators. Basically the code initially set the "external" BCs to zero and then set each "control" BC individually to get velocity fields with the right values. But it didn't reset the external BCs to zero in between, so the inflow was incorrectly nonzero for the BC velocity fields. This happened to cancel out if you had exactly asymmetric actuation.
Also found an easier way of deriving those BC fields in a more natural way for Firedrake (via projection, instead of asking for the Riesz representation of an assembled weak form).